-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] Use POST operation for node image version #10294
Merged
fengzhou-msft
merged 6 commits into
Azure:dev-containerservice-Microsoft.ContainerService-2020-07-01
from
gtxistxgao:tigao/upgradenodeimageversion
Aug 5, 2020
Merged
[AKS] Use POST operation for node image version #10294
fengzhou-msft
merged 6 commits into
Azure:dev-containerservice-Microsoft.ContainerService-2020-07-01
from
gtxistxgao:tigao/upgradenodeimageversion
Aug 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jul 29, 2020
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-net
|
azure-sdk-for-python
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jul 29, 2020
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 29, 2020
Can one of the admins verify this patch? |
gtxistxgao
force-pushed
the
tigao/upgradenodeimageversion
branch
from
July 29, 2020 20:48
74e5d24
to
cec4662
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
gtxistxgao
changed the title
Use POST operation for node image version
[AKS] Use POST operation for node image version
Jul 29, 2020
fengzhou-msft
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gtxistxgao - few comments
...erservice/resource-manager/Microsoft.ContainerService/stable/2020-07-01/managedClusters.json
Show resolved
Hide resolved
...erservice/resource-manager/Microsoft.ContainerService/stable/2020-07-01/managedClusters.json
Show resolved
Hide resolved
ravbhatnagar
added
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Jul 31, 2020
majastrz
added
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Aug 5, 2020
majastrz
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side.
fengzhou-msft
merged commit Aug 5, 2020
ef362e1
into
Azure:dev-containerservice-Microsoft.ContainerService-2020-07-01
PhoenixHe-NV
pushed a commit
that referenced
this pull request
Aug 19, 2020
* Adds base for updating Microsoft.ContainerService from version stable/2020-06-01 to version 2020-07-01 * Updates readme * Updates API version in new specs and examples * Add licenseType in WindowsProfile for AKS (#10050) * Change podsecuritypolicy description from PREVIEW to DEPRECATING. (#10175) * [AKS] Use POST operation for node image version (#10294) Co-authored-by: Xiaofang Zhang <[email protected]> Co-authored-by: Chou Hu <[email protected]> Co-authored-by: Jun Sun <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.